[
https://issues.apache.org/jira/browse/NIFI-5026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16417717#comment-16417717
]
ASF GitHub Bot commented on NIFI-5026:
--------------------------------------
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/2592
NIFI-5026: Refactored StandardPreparedQuery so that instead of a List…
… of Strings that may or may not correspond to compiled expressions and a
Map of String to Compiled Expression, the StandardPreparedQuery now just takes
a List of Expression objects, and those Expressions can be evaluated to return
the proper result
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markap14/nifi NIFI-5026
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2592.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2592
----
----
> Expression Language Query.prepare function can sometimes ignore escape
> sequence
> -------------------------------------------------------------------------------
>
> Key: NIFI-5026
> URL: https://issues.apache.org/jira/browse/NIFI-5026
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
> Reporter: Mark Payne
> Assignee: Mark Payne
> Priority: Major
> Fix For: 1.7.0
>
>
> As reported on the [[email protected]|mailto:[email protected]] mailing list:
>
> Hi,
> It looks like I have stumbled upon a bug in substitution of evaluated
> expressions.
> A test case:
> {code:java}
> String result =
> org.apache.nifi.attribute.expression.language.Query.prepare("${foo}$${foo}").evaluateExpressions(Collections.singletonMap("foo",
> "bar"), null);{code}
> Expected result:
> {code:java}
> bar${foo}{code}
> Observed result:
> {code:java}
> barbar{code}
> The issue exists in 1.5.0 and, as far as I can tell, in the master branch.The
> cause is quite simple: Query.prepare(...) splits the input string into pieces
> to be evaluated and substituted or to be copied literally, but it doesn't
> keep track of which is which.That couldn't possibly work. If a piece to be
> copied literally happens to be equal to one of the pieces to be substituted,
> the things go wrong, as the test case demonstrates.
> Regards,Sergei.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
