[ 
https://issues.apache.org/jira/browse/NIFI-4185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16421842#comment-16421842
 ] 

ASF GitHub Bot commented on NIFI-4185:
--------------------------------------

Github user JohannesDaniel commented on the issue:

    https://github.com/apache/nifi/pull/2587
  
    Hi @pvillard31 
    
    thank you for your comments! I realized all your suggestions. I like your 
news regarding the performance :-) Which kind of transformation did you test? 
XML => Record or XML => JSON (e. g. with ConvertRecord)?
    
    For any reason some tests disappeared for a certain commit at my local git 
(probably, I wanted to reorder the tests,  but deleted them, omg ...). However, 
I inserted them again (this is why there are many more tests now). 
    
    In addition, I adjusted the definition about how namespaces shall be 
treated. 
    
    I implemented several tests for XMLReader to verify that the usage of 
expression language works as expected.
    
    However, I was not able to reproduce your observation regarding the empty 
record for the header 
    ```
    <?xml version="1.0" encoding="utf-8"?>
    ```
    
    I implemented the following tests:
    ```
    testSimpleRecordWithHeader()
    testSimpleRecordWithHeaderNoValidation()
    ```
    
    Actually, they work as expected. 


> Add XML record reader & writer services
> ---------------------------------------
>
>                 Key: NIFI-4185
>                 URL: https://issues.apache.org/jira/browse/NIFI-4185
>             Project: Apache NiFi
>          Issue Type: New Feature
>          Components: Extensions
>    Affects Versions: 1.3.0
>            Reporter: Andy LoPresto
>            Assignee: Johannes Peter
>            Priority: Major
>              Labels: json, records, xml
>
> With the addition of the {{RecordReader}} and {{RecordSetWriter}} paradigm, 
> XML conversion has not yet been targeted. This will replace the previous 
> ticket for XML to JSON conversion. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to