Github user zenfenan commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2601#discussion_r178816076
  
    --- Diff: 
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch/QueryElasticsearchHttp.java
 ---
    @@ -68,8 +72,10 @@
             + "To retrieve more records, use the ScrollElasticsearchHttp 
processor.")
     @WritesAttributes({
             @WritesAttribute(attribute = "filename", description = "The 
filename attribute is set to the document identifier"),
    +        @WritesAttribute(attribute = "es.hitCount", description = "The 
number of hits for a query"),
    --- End diff --
    
    I believe, in general, it is a standard practice in the project to avoid 
casing `WritesAttributes` so shall we change it to `es.hit.count` or 
`es.hitcount` ?


---

Reply via email to