[
https://issues.apache.org/jira/browse/MINIFICPP-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16427509#comment-16427509
]
ASF GitHub Bot commented on MINIFICPP-445:
------------------------------------------
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/293#discussion_r179582611
--- Diff: libminifi/include/utils/StringUtils.h ---
@@ -88,7 +91,10 @@ class StringUtils {
*/
static inline bool equalsIgnoreCase(const std::string &left, const
std::string right) {
if (left.length() == right.length()) {
- return std::equal(right.begin(), right.end(), left.begin(),
[](unsigned char lc, unsigned char rc) {return std::tolower(lc) ==
std::tolower(rc);});
--- End diff --
I noticed you changed a lot of files outside of core. Can you keep these at
200 characters so we avoid unnecessary change later?
> Implement escape/unescape CSV functions in expression language
> --------------------------------------------------------------
>
> Key: MINIFICPP-445
> URL: https://issues.apache.org/jira/browse/MINIFICPP-445
> Project: NiFi MiNiFi C++
> Issue Type: Improvement
> Reporter: Andrew Christianson
> Assignee: Andrew Christianson
> Priority: Major
>
> *
> [escapeCsv|https://nifi.apache.org/docs/nifi-docs/html/expression-language-guide.html#escapecsv]
> *
> [unescapeCsv|https://nifi.apache.org/docs/nifi-docs/html/expression-language-guide.html#unescapecsv]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
