Github user markap14 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2587#discussion_r179840389
  
    --- Diff: 
nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/xml/XMLReader.java
 ---
    @@ -0,0 +1,133 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.nifi.xml;
    +
    +import org.apache.nifi.annotation.documentation.CapabilityDescription;
    +import org.apache.nifi.annotation.documentation.Tags;
    +import org.apache.nifi.annotation.lifecycle.OnEnabled;
    +import org.apache.nifi.components.PropertyDescriptor;
    +import org.apache.nifi.controller.ConfigurationContext;
    +import org.apache.nifi.logging.ComponentLog;
    +import org.apache.nifi.processor.util.StandardValidators;
    +import org.apache.nifi.schema.access.SchemaNotFoundException;
    +import org.apache.nifi.serialization.DateTimeUtils;
    +import org.apache.nifi.serialization.MalformedRecordException;
    +import org.apache.nifi.serialization.RecordReader;
    +import org.apache.nifi.serialization.RecordReaderFactory;
    +import org.apache.nifi.serialization.SchemaRegistryService;
    +import org.apache.nifi.serialization.record.RecordSchema;
    +
    +import java.io.IOException;
    +import java.io.InputStream;
    +import java.util.ArrayList;
    +import java.util.List;
    +import java.util.Map;
    +
    +@Tags({"xml", "record", "reader", "parser"})
    +@CapabilityDescription("Reads XML content and creates Record objects. 
Records are expected in the second level of " +
    --- End diff --
    
    More specifically, I think that if the following were the content of a 
FlowFile:
    ```
    <person>
      <name>John Doe</name>
      <id>123</id>
      <dob>01/01/2017</dob>
    </person>
    ```
    Then I would expect to have this parse as a single Record that would match 
this schema:
    ```
    {
      "name": "person", "namespace": "nifi",
      "type": "record",
      "fields": [
        { "name": "name", "type": "string" },
        { "name": "id", "type": "int" },
        { "name": "dob", "type": "date" }
      ]
    }
    ```
    Additionally, I would expect to be able to set a property that indicates 
that the outer-most XML element is simply a wrapper. If that property were set 
to "true", then I would expect to use that exact same schema to parse the 
following XML:
    ```
    <people>
      <person>
        <name>John Doe</name>
        <id>123</id>
        <dob>01/01/2017</dob>
      </person>
      <person>
        <name>Jane Doe</name>
        <id>124</id>
        <dob>01/01/2016</dob>
      </person>
      <person>
        <name>Jake Doe</name>
        <id>125</id>
        <dob>01/01/2015</dob>
      </person>
    </people>
    ```
    In this case, the 'people' element is just a wrapper and could just as 
easily be an element named 'root' or 'foo' or 'bar'.


---

Reply via email to