Github user phrocker commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/296#discussion_r180264700
  
    --- Diff: main/CMakeLists.txt ---
    @@ -66,7 +66,7 @@ else ()
        target_link_libraries (minifiexe -Wl,--whole-archive minifi 
-Wl,--no-whole-archive)
     endif ()
     
    -target_link_libraries(minifiexe yaml-cpp ${UUID_LIBRARIES} 
${OPENSSL_LIBRARIES})
    +target_link_libraries(minifiexe yaml-cpp ${UUID_LIBRARIES} 
${CURL_LIBRARIES} ${OPENSSL_LIBRARIES})
    --- End diff --
    
    This should not be included here. It should be passed transitively through 
the minifi-http-curl iff it is enabled. 


---

Reply via email to