[ 
https://issues.apache.org/jira/browse/NIFI-4927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16432131#comment-16432131
 ] 

ASF GitHub Bot commented on NIFI-4927:
--------------------------------------

Github user MikeThomsen commented on the issue:

    https://github.com/apache/nifi/pull/2562
  
    @mans2singh I went to merge your changes this morning and found that you 
have some integration tests that are broken now with the changes made to EL 
support in the `PropertyDescriptor.Builder` class. It seems your breakage is 
limited mainly here:
    
    ```
    protected String makeProvenanceUrl(final ProcessContext context, String 
database, FlowFile flowFile) {
        return new StringBuilder("influxdb://")
            
.append(context.getProperty(INFLUX_DB_URL).evaluateAttributeExpressions(flowFile).getValue()).append("/")
            .append(database).toString();
    }
    ```
    
    You marked that property as `VARIABLE_REGISTRY` and it is failing because 
you're applying it flowfiles. The existing calls to 
`expressionLanguageSupported(boolean)` in the abstract class also need to be 
fixed.
    
    So just do a rebase against the latest master and take care of those. If 
there are no regressions after your commit (ie your flows and tests run) IMO 
we're ready to merge.


> Create InfluxDB Query Processor
> -------------------------------
>
>                 Key: NIFI-4927
>                 URL: https://issues.apache.org/jira/browse/NIFI-4927
>             Project: Apache NiFi
>          Issue Type: New Feature
>          Components: Extensions
>    Affects Versions: 1.5.0
>            Reporter: Mans Singh
>            Assignee: Mans Singh
>            Priority: Minor
>              Labels: measurements,, query, realtime, timeseries
>
> Create InfluxDB Query processor



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to