[
https://issues.apache.org/jira/browse/NIFI-5055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16433020#comment-16433020
]
ASF GitHub Bot commented on NIFI-5055:
--------------------------------------
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2617
@MikeThomsen - just fyi, while merging a PR it's highly recommended to
amend the commit message to include the magic words that will automatically
close the github PR. The commands I usually execute when merging a PR are:
````
git checkout master
git pull origin master
git fetch github
git checkout github/pr/<PR ID>
git checkout -b pr<PR ID>
--- here you can do additional reviewing, maven builds, test with a running
instance, etc ---
git commit --amend -s
--- you update the commit message to include "This closes #<PR ID>."
git log
--- the above command is to retrieve the commit ID ---
git checkout master
git cherry-pick <commit ID>
git push origin master
````
This is an example - there are probably other ways to do it.
> Need ability to un-penalize MockFlowFile
> ----------------------------------------
>
> Key: NIFI-5055
> URL: https://issues.apache.org/jira/browse/NIFI-5055
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework
> Affects Versions: 1.6.0
> Reporter: Mark Bean
> Assignee: Mark Bean
> Priority: Major
>
> The MockFlowFile has a method setPenalized() which sets the 'penalized'
> variable to true. And, the isPenalized() method simply returns the value of
> 'penalized'. (In the real world, isPenalized() is time-based.) I believe an
> unsetPenalized() method may be needed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
