[
https://issues.apache.org/jira/browse/NIFI-5049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16433390#comment-16433390
]
ASF GitHub Bot commented on NIFI-5049:
--------------------------------------
GitHub user gardellajuanpablo opened a pull request:
https://github.com/apache/nifi/pull/2625
NIFI-5049 Fix handling of Phonenix datetime columns
Fixed Error: ERROR 203 (22005): Type mismatch. TIMESTAMP
and VARCHAR for <COLUMN_NAME> = '2015-09-12 18:19:43.293'
(sample date).
The fix consists on applying the same fix added to Oracle DB,
based on NIFI-2323 approach. The changes introduced were:
1) A Phoenix database adapter.
2) Handling timestamp, date and time in Phoenix.
3) Added a close to result set in QueryDatabaseTable processor
(not related to this bug, but I think it will be useful to
fix).
The changes don't break existing code.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gardellajuanpablo/nifi NIFI-5049
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2625.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2625
----
commit 20f2638e7f792ec84f61ea42f135587e2f30ea1f
Author: Gardella Juan Pablo <gardellajuanpablo@...>
Date: 2018-04-11T04:23:00Z
NIFI-5049 Fix handling of Phonenix datetime columns
Fixed Error: ERROR 203 (22005): Type mismatch. TIMESTAMP
and VARCHAR for <COLUMN_NAME> = '2015-09-12 18:19:43.293'
(sample date).
The fix consists on applying the same fix added to Oracle DB,
based on NIFI-2323 approach. The changes introduced were:
1) A Phoenix database adapter.
2) Handling timestamp, date and time in Phoenix.
3) Added a close to result set in QueryDatabaseTable processor
(not related to this bug, but I think it will be useful to
fix).
The changes don't break existing code.
----
> Fixhandling of Phonenix datetime columns in QueryDatabaseTable and
> GenerateTableFetch
> -------------------------------------------------------------------------------------
>
> Key: NIFI-5049
> URL: https://issues.apache.org/jira/browse/NIFI-5049
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
> Affects Versions: 1.5.0
> Reporter: Gardella Juan Pablo
> Assignee: Matt Burgess
> Priority: Major
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> QueryDatabaseAdapter does not work against Phoenix DB if it should convert
> TIMESTAMP. The error is described below:
> [https://stackoverflow.com/questions/45989678/convert-varchar-to-timestamp-in-hbase]
> Basically, it's required to use TO_TIMESTAMP(MAX_COLUMN) to make it work.
> See
> [https://lists.apache.org/thread.html/%3cca+kifscje8ay+uxt_d_vst4qgzf4jxwovboynjgztt4dsbs...@mail.gmail.com%3E]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
