Github user MikeThomsen commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2625#discussion_r180732541
  
    --- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/QueryDatabaseTableTest.java
 ---
    @@ -159,6 +160,35 @@ public void testGetQuery() throws Exception {
             dbAdapter = new OracleDatabaseAdapter();
             query = processor.getQuery(dbAdapter, "myTable", null, 
Arrays.asList("id", "DATE_CREATED"), "type = \"CUSTOMER\"", 
stateManager.getState(Scope.CLUSTER).toMap());
             assertEquals("SELECT * FROM myTable WHERE id > 509 AND 
DATE_CREATED >= timestamp '2016-03-07 12:34:56' AND (type = \"CUSTOMER\")", 
query);
    +
    --- End diff --
    
    Can you break this out into a separate unit test? We don't want a failure 
in the Oracle unit test to block the Phoenix test from running.


---

Reply via email to