[ 
https://issues.apache.org/jira/browse/NIFI-5049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16433820#comment-16433820
 ] 

ASF GitHub Bot commented on NIFI-5049:
--------------------------------------

Github user MikeThomsen commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2625#discussion_r180732541
  
    --- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/QueryDatabaseTableTest.java
 ---
    @@ -159,6 +160,35 @@ public void testGetQuery() throws Exception {
             dbAdapter = new OracleDatabaseAdapter();
             query = processor.getQuery(dbAdapter, "myTable", null, 
Arrays.asList("id", "DATE_CREATED"), "type = \"CUSTOMER\"", 
stateManager.getState(Scope.CLUSTER).toMap());
             assertEquals("SELECT * FROM myTable WHERE id > 509 AND 
DATE_CREATED >= timestamp '2016-03-07 12:34:56' AND (type = \"CUSTOMER\")", 
query);
    +
    --- End diff --
    
    Can you break this out into a separate unit test? We don't want a failure 
in the Oracle unit test to block the Phoenix test from running.


> Fix handling of Phonenix datetime columns in QueryDatabaseTable and 
> GenerateTableFetch
> --------------------------------------------------------------------------------------
>
>                 Key: NIFI-5049
>                 URL: https://issues.apache.org/jira/browse/NIFI-5049
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Core Framework
>    Affects Versions: 1.5.0
>            Reporter: Gardella Juan Pablo
>            Assignee: Matt Burgess
>            Priority: Major
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> QueryDatabaseAdapter does not work against Phoenix DB if it should convert 
> TIMESTAMP. The error is described below:
> [https://stackoverflow.com/questions/45989678/convert-varchar-to-timestamp-in-hbase]
> Basically, it's required to use TO_TIMESTAMP(MAX_COLUMN) to make it work. 
> See 
> [https://lists.apache.org/thread.html/%3cca+kifscje8ay+uxt_d_vst4qgzf4jxwovboynjgztt4dsbs...@mail.gmail.com%3E]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to