[ 
https://issues.apache.org/jira/browse/NIFI-4952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16433838#comment-16433838
 ] 

ASF GitHub Bot commented on NIFI-4952:
--------------------------------------

Github user MikeThomsen commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2572#discussion_r180735170
  
    --- Diff: 
nifi-nar-bundles/nifi-websocket-bundle/nifi-websocket-services-jetty/src/main/java/org/apache/nifi/websocket/jetty/JettyWebSocketClient.java
 ---
    @@ -142,10 +142,10 @@ public void startClient(final ConfigurationContext 
context) throws Exception{
             client.start();
             activeSessions.clear();
     
    -        webSocketUri = new URI(context.getProperty(WS_URI).getValue());
    -        connectionTimeoutMillis = 
context.getProperty(CONNECTION_TIMEOUT).asTimePeriod(TimeUnit.MILLISECONDS);
    +        webSocketUri = new 
URI(context.getProperty(WS_URI).evaluateAttributeExpressions().getValue());
    --- End diff --
    
    It looks like you're still using `expressionLanguageSupported(boolean)` in 
this PR. Please rebase off of the latest master and add change it 
`expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY)`.


> JettyWebSocketClient websocket-uri property missing 
> evaluateAttributeExpressions
> --------------------------------------------------------------------------------
>
>                 Key: NIFI-4952
>                 URL: https://issues.apache.org/jira/browse/NIFI-4952
>             Project: Apache NiFi
>          Issue Type: Bug
>    Affects Versions: 1.5.0
>            Reporter: Sven Van Hemel
>            Priority: Major
>
> The {{websocket-uri property}} of the 
> {{org.apache.nifi.websocket.jetty.JettyWebSocketClient}} class is marked as 
> EL enabled, but its evaluation in the {{startClient()}} method seems to be 
> missing a {{evaluateAttributeExpressions()}} call.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to