[
https://issues.apache.org/jira/browse/NIFI-5049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16434038#comment-16434038
]
ASF GitHub Bot commented on NIFI-5049:
--------------------------------------
Github user gardellajuanpablo commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2625#discussion_r180787552
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/db/impl/PhoenixDatabaseAdapter.java
---
@@ -0,0 +1,72 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.processors.standard.db.impl;
+
+import org.apache.commons.lang3.StringUtils;
+import org.apache.nifi.processors.standard.db.DatabaseAdapter;
+
+/**
+ * A Apache Phoenix database adapter that generates ANSI SQL.
+ */
+public final class PhoenixDatabaseAdapter implements DatabaseAdapter {
+ public static final String NAME = "Phoenix";
+
+ @Override
+ public String getName() {
+ return NAME;
+ }
+
+ @Override
+ public String getDescription() {
+ return "Generates Phoenix compliant SQL";
+ }
+
+ @Override
+ public String getSelectStatement(String tableName, String columnNames,
String whereClause, String orderByClause,
--- End diff --
Yes, tt will prevent duplicate code, but any change introduced in
GenericDatabaseAdapter may break Phoenix adapter. Also PhoenixDatabaseAdapter
it is not (my personal opinion) a Generic Adapter. Having in this way, it's
less risk introducing changes in Generic/Phoenix Adapter.
> Fix handling of Phonenix datetime columns in QueryDatabaseTable and
> GenerateTableFetch
> --------------------------------------------------------------------------------------
>
> Key: NIFI-5049
> URL: https://issues.apache.org/jira/browse/NIFI-5049
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
> Affects Versions: 1.5.0
> Reporter: Gardella Juan Pablo
> Assignee: Matt Burgess
> Priority: Major
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> QueryDatabaseAdapter does not work against Phoenix DB if it should convert
> TIMESTAMP. The error is described below:
> [https://stackoverflow.com/questions/45989678/convert-varchar-to-timestamp-in-hbase]
> Basically, it's required to use TO_TIMESTAMP(MAX_COLUMN) to make it work.
> See
> [https://lists.apache.org/thread.html/%3cca+kifscje8ay+uxt_d_vst4qgzf4jxwovboynjgztt4dsbs...@mail.gmail.com%3E]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
