[
https://issues.apache.org/jira/browse/NIFI-5070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16434738#comment-16434738
]
ASF GitHub Bot commented on NIFI-5070:
--------------------------------------
GitHub user gardellajuanpablo opened a pull request:
https://github.com/apache/nifi/pull/2629
NIFI-5070 Fix java.sql.SQLException: ERROR 1101 (XCL01): ResultSet is…
… closed
Discovered on Phoenix Database by using QueryDatabaseTable processor. The
fix consists
on applying Matt Burgess' suggestion:
"I think we'd need a try/catch around the next() only to see if the result
set is closed,
and an inner try/catch around everything else, to catch other errors not
related to
this behavior. "
The solution was verified against Phoenix DB. Also added unit tests to
cover the
change.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gardellajuanpablo/nifi NIFI-5070
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2629.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2629
----
commit 859616f300986e62bd613cb3fd8cc05d823952c6
Author: Gardella Juan Pablo <gardellajuanpablo@...>
Date: 2018-04-11T23:53:17Z
NIFI-5070 Fix java.sql.SQLException: ERROR 1101 (XCL01): ResultSet is closed
Discovered on Phoenix Database by using QueryDatabaseTable processor. The
fix consists
on applying Matt Burgess' suggestion:
"I think we'd need a try/catch around the next() only to see if the result
set is closed,
and an inner try/catch around everything else, to catch other errors not
related to
this behavior. "
The solution was verified against Phoenix DB. Also added unit tests to
cover the
change.
----
> java.sql.SQLException: ERROR 1101 (XCL01): ResultSet is closed
> --------------------------------------------------------------
>
> Key: NIFI-5070
> URL: https://issues.apache.org/jira/browse/NIFI-5070
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
> Affects Versions: 1.6.0
> Reporter: Gardella Juan Pablo
> Priority: Major
>
> Discovered during NIFI-5049. According [ResultSet.next()
> javadoc|https://docs.oracle.com/javase/8/docs/api/java/sql/ResultSet.html#next%E2%80%93]:
> _When a call to the {{next}} method returns {{false}}, the cursor is
> positioned after the last row. Any invocation of a {{ResultSet}} method which
> requires a current row will result in a {{SQLException}} being thrown. If the
> result set type is {{TYPE_FORWARD_ONLY}}, it is vendor specified whether
> their JDBC driver implementation will return {{false}} or throw an
> {{SQLException}} on a subsequent call to {{next}}._
> With Phoenix Database and QueryDatabaseTable the exception
> {{java.sql.SQLException: ERROR 1101 (XCL01): ResultSet is closed}} is raised.
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
