[ 
https://issues.apache.org/jira/browse/NIFI-5062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16439567#comment-16439567
 ] 

ASF GitHub Bot commented on NIFI-5062:
--------------------------------------

GitHub user zenfenan opened a pull request:

    https://github.com/apache/nifi/pull/2636

    NIFI-5062: Removed hbase-client dependecy from hbase bundle

    Since the `MockHBaseClientService` and `TestPutHBaseRecord` extensively 
uses `Bytes` class, I have created a new class here and literally copied the 
relevant methods from the actual `Bytes` class to this one.
    
    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [x] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zenfenan/nifi NIFI-5062

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/2636.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2636
    
----
commit a34ca612464a115d03e7e7ca6ef7e08c06045d4f
Author: zenfenan <sivaprasanna246@...>
Date:   2018-04-14T06:04:07Z

    NIFI-5062: Removed hbase-client dependecy from hbase bundle

----


> Remove hbase-client from nifi-hbase-bundle pom
> ----------------------------------------------
>
>                 Key: NIFI-5062
>                 URL: https://issues.apache.org/jira/browse/NIFI-5062
>             Project: Apache NiFi
>          Issue Type: Improvement
>    Affects Versions: 1.6.0
>            Reporter: Bryan Bende
>            Assignee: Sivaprasanna Sethuraman
>            Priority: Minor
>
> Since the hbase-client dependency should be coming from the client service 
> implementation, we shouldn't need to specify it here:
> [https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-hbase-bundle/pom.xml#L43]
> We should also make hbase.version a property that can be overridden at build 
> time, rather than hard-coding it here:
> https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-standard-services/nifi-hbase_1_1_2-client-service-bundle/nifi-hbase_1_1_2-client-service/pom.xml#L73



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to