[
https://issues.apache.org/jira/browse/NIFI-5085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16440294#comment-16440294
]
ASF GitHub Bot commented on NIFI-5085:
--------------------------------------
GitHub user JPercivall opened a pull request:
https://github.com/apache/nifi/pull/2637
NIFI-5085 In InvokeHttp, moving the OkHttp Response object to a try w…
…ith resources
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [X] Is your initial contribution a single, squashed commit?
### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [X] Have you written or updated unit tests to verify your changes?
- [X] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [X] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [X] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [X] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [X] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/JPercivall/nifi
NIFI-5085_closing_OkHttpResponse_in_InvokeHttp
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2637.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2637
----
commit a320601fbd20f9ae77044c9babe2728dc89d6426
Author: Joe Percivall <jpercivall@...>
Date: 2018-04-17T02:36:26Z
NIFI-5085 In InvokeHttp, moving the OkHttp Response object to a try with
resources
----
> InvokeHttp does not close the response in all cases
> ---------------------------------------------------
>
> Key: NIFI-5085
> URL: https://issues.apache.org/jira/browse/NIFI-5085
> Project: Apache NiFi
> Issue Type: Bug
> Affects Versions: 1.4.0, 1.5.0, 1.6.0
> Reporter: Joseph Percivall
> Assignee: Joseph Percivall
> Priority: Major
>
> As stated in this github issue for OkHttp[1] (the library InvokeHttp uses),
> the response needs to be closed for every instance of the response.
> InvokeHttp currently only closes the underlying body stream in the instance
> of there existing a body[2][3]. The proper way to do it is how the
> HttpNotificationService does, utilizing a try with resources on the
> response[4].
>
> I ran into this issue when my 1.5.0 instance hit OOM errors multiple times.
> I'm still not a 100% sure this is the root cause but one common thing between
> those OOM errors is repeated socket timeout exceptions in InvokeHttp (and
> even if it's not, it should still be fixed).
>
> [1] https://github.com/square/okhttp/issues/2311
> [2]
> https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java#L822
>
> [3]
> https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java#L894
>
> [4]
> https://github.com/apache/nifi/blob/master/nifi-bootstrap/src/main/java/org/apache/nifi/bootstrap/notification/http/HttpNotificationService.java#L230
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
