[
https://issues.apache.org/jira/browse/NIFI-5090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16442044#comment-16442044
]
ASF GitHub Bot commented on NIFI-5090:
--------------------------------------
GitHub user ijokarumawak opened a pull request:
https://github.com/apache/nifi/pull/2642
NIFI-5090: Create move target dir dynamically at FetchFTP and FetchSFTP
## NOTES
This PR contains two commits. The first one 3dc909d is mandatory.
The 2nd one 8ec8a25 improves 'disable directory listing' scenario. Before
this commit, if directory listing was disabled and parent directory was not
found, FetchSFTP did not try creating the missing parent directories. The 2nd
commit made the processor to create parent directories. It affects to PutSFTP,
too.
I didn't create another JIRA for the 2nd commit, since these can be tested
and reviewed easier at the same time. Please let me know if you, reviewer think
it should be managed separately.
I used following docker images for testing:
- atmoz/sftp
- stilliard/pure-ftpd:hardened
A NiFi flow template is also available here:
https://gist.github.com/ijokarumawak/4fb05da103fd10f3ae6038f3388eb062
Thanks!
---
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ijokarumawak/nifi nifi-5090
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2642.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2642
----
commit 3dc909d2820c8355153f220a6f63d25aae9341d7
Author: Koji Kawamura <ijokarumawak@...>
Date: 2018-04-18T02:14:41Z
NIFI-5090: Create move target dir dynamically at FetchFTP and FetchSFTP
commit 8ec8a25989d8b9753c8596591c1a3df419bcedfa
Author: Koji Kawamura <ijokarumawak@...>
Date: 2018-04-18T07:08:04Z
Support creating target parent directories even if directory listing is
disabled.
----
> FetchFTP and FetchSFTP should be able to dynamically create the target
> directory to move files to if not found
> --------------------------------------------------------------------------------------------------------------
>
> Key: NIFI-5090
> URL: https://issues.apache.org/jira/browse/NIFI-5090
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
> Reporter: Koji Kawamura
> Assignee: Koji Kawamura
> Priority: Major
>
> When using FetchFTP or FetchSFTP with "Completion Strategy" "Move" files it
> allows you to specify a directory that files are moved to.
> The directory to move files to has to exist for the files to be moved there.
> But it will be useful if fetch FTP processors create a directory using some
> attribute data, so that processed files are moved into a folder called:
> "processed/${year}/${month}/${day}"
> Currently with this format, the system creates an exception "FileNotFound"
> which actually appears to be referring to the destination directory not being
> found.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
