[
https://issues.apache.org/jira/browse/NIFI-5092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16442231#comment-16442231
]
ASF GitHub Bot commented on NIFI-5092:
--------------------------------------
GitHub user pvillard31 opened a pull request:
https://github.com/apache/nifi/pull/2643
NIFI-5092 - Removed local state management for S2S Bulletins RT
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pvillard31/nifi NIFI-5092
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2643.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2643
----
commit a86d26f1282265bbd785ca205dfe812dd6c91f4b
Author: Pierre Villard <pierre.villard.fr@...>
Date: 2018-04-18T10:21:04Z
NIFI-5092 - Removed local state management for S2S Bulletins RT
----
> S2S Bulletin Reporting Task will not send recent bulletins after a restart
> --------------------------------------------------------------------------
>
> Key: NIFI-5092
> URL: https://issues.apache.org/jira/browse/NIFI-5092
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
> Affects Versions: 1.2.0, 1.3.0, 1.4.0, 1.5.0, 1.6.0
> Reporter: Pierre Villard
> Assignee: Pierre Villard
> Priority: Major
>
> Bulletins are stored in memory by NiFi on a 5-minutes rolling window. Each
> bulletin has a bulletin ID and it starts with the value 0. Upon NiFi
> restarts, the new generated bulletins will also have an ID starting with the
> value 0.
> Currently the reporting task is locally storing the ID of the last bulletin
> sent through S2S. But this should not be the case because if the last
> bulletin ID is X when NiFi is restarted, then all new generated bulletins
> with ID <= X will be ignored.
> The state management of this reporting task should be completely removed.
> Starting/stopping the reporting task won't be impacting the behavior since
> the ID of the last bulletin sent is stored in local variable.
> *Current workaround* - after a NiFi restart, stop the reporting task, clear
> the state of the reporting task and start the reporting task.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
