[
https://issues.apache.org/jira/browse/NIFI-4647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16443031#comment-16443031
]
ASF GitHub Bot commented on NIFI-4647:
--------------------------------------
GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/2644
NIFI-4647: Fix support for strings in unions for ConvertAvroToORC
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mattyb149/nifi NIFI-4647
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2644.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2644
----
commit 1f3c1e0b0ddd5565a67740c1830458fbff2ea490
Author: Matthew Burgess <mattyb149@...>
Date: 2018-04-18T18:49:16Z
NIFI-4647: Fix support for strings in unions for ConvertAvroToORC
----
> ConvertAvroToORC fails if the avro schema uses a union of a null, string, and
> long
> ----------------------------------------------------------------------------------
>
> Key: NIFI-4647
> URL: https://issues.apache.org/jira/browse/NIFI-4647
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
> Reporter: Benjamin Garrett
> Assignee: Matt Burgess
> Priority: Major
>
> If an avro schema has a field defined like this:
> {"name":"myStringOrLong","type":["null","string","long"],"default":null}
> then when we run ConvertAvroToORC we get the following error:
> Object Type for class org.apache.avro.util.Utf8 not in Union declaration
> This is because Avro uses its internal Utf8 class (instead of 'String') as a
> performance optimization as discussed elsewhere on the internet, such as
> here:
> http://apache-avro.679487.n3.nabble.com/why-Utf8-vs-String-td3247788.html
> but the NiFiOrcUtils class is not expecting the Utf8 class to be used for
> 'string' types.
> A simple workaround is to modify NiFiOrcUtils lines 72-73 to be something
> like this:
> Class clazzToCompareTo = o.getClass();
> if (o instanceof org.apache.avro.util.Utf8 ) {
> clazzToCompareTo = String.class;
> }
> TypeInfo objectTypeInfo =
> TypeInfoUtils.getTypeInfoFromObjectInspector(
> ObjectInspectorFactory.getReflectionObjectInspector(
> clazzToCompareTo,
> ObjectInspectorFactory.ObjectInspectorOptions.JAVA));
> This solution works for me.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
