Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2587#discussion_r183152900
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/xml/XMLReader.java
---
@@ -0,0 +1,133 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.nifi.xml;
+
+import org.apache.nifi.annotation.documentation.CapabilityDescription;
+import org.apache.nifi.annotation.documentation.Tags;
+import org.apache.nifi.annotation.lifecycle.OnEnabled;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.controller.ConfigurationContext;
+import org.apache.nifi.logging.ComponentLog;
+import org.apache.nifi.processor.util.StandardValidators;
+import org.apache.nifi.schema.access.SchemaNotFoundException;
+import org.apache.nifi.serialization.DateTimeUtils;
+import org.apache.nifi.serialization.MalformedRecordException;
+import org.apache.nifi.serialization.RecordReader;
+import org.apache.nifi.serialization.RecordReaderFactory;
+import org.apache.nifi.serialization.SchemaRegistryService;
+import org.apache.nifi.serialization.record.RecordSchema;
+
+import java.io.IOException;
+import java.io.InputStream;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Map;
+
+@Tags({"xml", "record", "reader", "parser"})
+@CapabilityDescription("Reads XML content and creates Record objects.
Records are expected in the second level of " +
--- End diff --
Yes, exactly. I would use a property to convey this. I would be okay with
allowing Expression Language to be used, or just allowing for a 'true'/'false'
without Expression Language (I think in most cases, you'll want one or the
other, not dependent upon each individual FlowFile). But if you think EL is
important then I won't argue that point :)
One other option, which we do in a few different processors, would be to
offer a third option that looks at a well-known attribute. So you could choose
'true' (treat outer element as a wrapper), 'false' (treat each flowfile as a
single record), or 'use xml.stream attribute', and when that is selected, the
'xml.stream' attribute would be looked at to determine how to handle it - a
value of 'true' would mean it's a stream of multiple records, 'false' would
mean it's only 1 record, missing or any other value would throw an Exception. I
don't have strong preference one way or another how this should be handled,
but wanted to present options that we typically use.
---
