Github user markap14 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2640#discussion_r183159695
  
    --- Diff: 
nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/json/AbstractJsonRowRecordReader.java
 ---
    @@ -197,7 +193,8 @@ private JsonNode getNextJsonNode() throws 
JsonParseException, IOException, Malfo
                         return jsonParser.readValueAsTree();
                     case END_ARRAY:
                     case START_ARRAY:
    -                    return null;
    +                    return getNextJsonNode();
    --- End diff --
    
    Would recommend that we just use 'continue' here as we do for END_OBJECT, 
rather than recursively calling ourselves. Is consistent and avoids 
unnecessarily deepening the stack, but will result in the same logic being 
evaluated


---

Reply via email to