[
https://issues.apache.org/jira/browse/NIFI-4456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16446335#comment-16446335
]
ASF GitHub Bot commented on NIFI-4456:
--------------------------------------
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2640#discussion_r183159695
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/json/AbstractJsonRowRecordReader.java
---
@@ -197,7 +193,8 @@ private JsonNode getNextJsonNode() throws
JsonParseException, IOException, Malfo
return jsonParser.readValueAsTree();
case END_ARRAY:
case START_ARRAY:
- return null;
+ return getNextJsonNode();
--- End diff --
Would recommend that we just use 'continue' here as we do for END_OBJECT,
rather than recursively calling ourselves. Is consistent and avoids
unnecessarily deepening the stack, but will result in the same logic being
evaluated
> Update JSON Record Reader / Writer to allow for 'json per line' format
> ----------------------------------------------------------------------
>
> Key: NIFI-4456
> URL: https://issues.apache.org/jira/browse/NIFI-4456
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
> Reporter: Mark Payne
> Assignee: Matt Burgess
> Priority: Major
>
> It is common, especially for archiving purposes, to have many JSON objects
> combined with new-lines in between, in order to delimit the records. It would
> be useful to allow record readers and writers to support this, instead of
> requiring that JSON records being elements in a JSON Array.
> For example, the following JSON Is considered two records:
> {code}
> [
> { "greeting" : "hello", "id" : 1 },
> { "greeting" : "good-bye", "id" : 2 }
> ]
> {code}
> It would be beneficial to also support the format:
> {code}
> { "greeting" : "hello", "id" : 1 }
> { "greeting" : "good-bye", "id" : 2 }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
