[
https://issues.apache.org/jira/browse/NIFI-5073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16450106#comment-16450106
]
ASF GitHub Bot commented on NIFI-5073:
--------------------------------------
GitHub user zenfenan opened a pull request:
https://github.com/apache/nifi/pull/2653
NIFI-5073: JMSConnectionFactoryProvider now resolves EL Expression
JMSConnectionFactoryProvider now resolves EL Expression from
VariableRegistry.
**Summary**
- Replaced custom file validator with
`StandardValidators.createURLorFileValidator`
- `BROKER_URI` was not properly evaluated. Fixed it.
- Added a unit test to confirm that EL expressions are properly evaluated
and validated
---
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zenfenan/nifi NIFI-5073
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2653.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2653
----
commit ab297714e64536625bbbe2f60262fd56be26d64a
Author: zenfenan <sivaprasanna246@...>
Date: 2018-04-24T15:35:05Z
NIFI-5073: JMSConnectionFactoryProvider now resolves EL Expression from
VariableRegistry
----
> Process Group defined "variables" are not being properly used by in scope
> controller services
> ---------------------------------------------------------------------------------------------
>
> Key: NIFI-5073
> URL: https://issues.apache.org/jira/browse/NIFI-5073
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
> Affects Versions: 1.5.0, 1.6.0
> Reporter: Matthew Clarke
> Assignee: Sivaprasanna Sethuraman
> Priority: Major
>
> Create a new process Group.
> Add "Variables" to the process group:
> for example:
> broker_uri=tcp://localhost:4141
> client_libs=/NiFi/custom-lib-dir/MQlib
> con_factory=blah
> Then while that process group is selected, create a controller service.
> Create JMSConnectionFactory.
> Configure this controller service to use EL for PG defined variables above:
> ${con_factory}, ${con_factory}, and ${broker_uri}
> The controller service will remain invalid because the EL statements are not
> properly resolved to their set values.
> Doing the exact same thing above using the external NiFi registry file works
> as expected.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
