[
https://issues.apache.org/jira/browse/NIFI-5120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452133#comment-16452133
]
ASF GitHub Bot commented on NIFI-5120:
--------------------------------------
GitHub user sbouchex opened a pull request:
https://github.com/apache/nifi/pull/2654
NIFI-5120 Added expression language support to AbstractListenEventProcessor
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [X ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ X] Is your initial contribution a single, squashed commit?
### For code changes:
- [ X] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ X] Have you written or updated unit tests to verify your changes?
- [ X] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ X] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ X] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ X] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ X] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/infovista/nifi listener_changes
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2654.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2654
----
commit 7642c1a3194810c6cff0377475c26372f0a32fb0
Author: sbouchex <sbouchex@...>
Date: 2018-04-25T12:02:30Z
AbstractListenEventProcessor.PORT now supports expression language
commit ecf97bd238416f6be85f4cb79a737f1791ddbfe5
Author: sbouchex <sbouchex@...>
Date: 2018-04-25T12:03:09Z
Revert "AbstractListenEventProcessor.PORT now supports expression language"
This reverts commit 7642c1a3194810c6cff0377475c26372f0a32fb0.
commit 783dad0892d4654afc936fdc69468d4ce5bc5a25
Author: sbouchex <sbouchex@...>
Date: 2018-04-25T12:05:58Z
AbstractListenEventProcessor.PORT now supports expression language
----
> AbstractListenEventProcessor should support expression language
> ---------------------------------------------------------------
>
> Key: NIFI-5120
> URL: https://issues.apache.org/jira/browse/NIFI-5120
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
> Affects Versions: 1.6.0
> Environment: All
> Reporter: Sébastien Bouchex Bellomié
> Priority: Minor
>
> Current implementation of AbstractListenEventProcessor only supports fixed
> value whereas using expression language can be usefull while using properties.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
