[
https://issues.apache.org/jira/browse/NIFI-5119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452180#comment-16452180
]
ASF GitHub Bot commented on NIFI-5119:
--------------------------------------
GitHub user jomach opened a pull request:
https://github.com/apache/nifi/pull/2656
NIFI-5119: Pulling changes from Registry does not respect sensitive
Informations on Destination
* Fix missing sensetive information.
* missing unit test
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jomach/nifi master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2656.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2656
----
commit 07f4ccb2cf4f25922ae6f1dade3ff71da9143433
Author: Jorge Machado <jorgewilson.machado@...>
Date: 2018-04-25T12:37:20Z
NIFI-5119
* Fix missing sensetive information.
* missing unit test
----
> Pulling changes from Registry does not respect sensitive Informations on
> Destination
> ------------------------------------------------------------------------------------
>
> Key: NIFI-5119
> URL: https://issues.apache.org/jira/browse/NIFI-5119
> Project: Apache NiFi
> Issue Type: Bug
> Components: Variable Registry
> Affects Versions: 1.5.0, 1.6.0
> Environment: all
> Reporter: Jorge Machado
> Priority: Major
> Fix For: 1.7.0
>
>
> When pulling changes from registry if a sensitive variable is set then it
> gets reset to its default.
> I have found out a use case that destroys the complete concept of the
> Registry.
> # Setup a flow with a sensitive field on Nifi Server A.
> # Push that to Registry
> # Pull the Flow in Nifi Server B. (this is expected to be reseted because
> is the first time)
> # Make changes on Nifi Server B and Push
> # Pull the changes from Nifi Server A.
>
> On Step 5 the sensitive Information from Nifi Server A get's deleted.
> This breaks the whole concept IMHO.
> Relates to : NIFI-5028
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
