[
https://issues.apache.org/jira/browse/NIFI-543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452827#comment-16452827
]
ASF GitHub Bot commented on NIFI-543:
-------------------------------------
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2509#discussion_r184162346
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-processor-configuration.js
---
@@ -741,8 +742,8 @@
}
});
- // show the execution node option if we're cluster or
we're currently configured to run on the primary node only
- if (nfClusterSummary.isClustered() || executionNode
=== 'PRIMARY') {
+ // show the execution node option if we're clustered
and execution node is not restricted to run only in primary node
+ if (nfClusterSummary.isClustered() &&
executionNodeRestricted !== true) {
--- End diff --
@zenfenan Sorry, I missed the mentions here. Always feel free to push
subsequent commits as we're working through the PR process. It's much easier to
review when I pull down the changes locally. What your suggesting above is
exactly what I was thinking. I agree that the conditional is a bit confusing. I
wonder if we attempt to break it up a little bit if it would be more clear.
Maybe something like
`
if (nfClusterSummary.isClustered()) {
if (executionNodeRestricted !== true ||
executionNode === 'ALL') {
$('#execution-node-options').show();
} else {
$('#execution-node-options').hide();
}
} else {
if (executionNode === 'PRIMARY') {
$('#execution-node-options').show();
} else {
$('#execution-node-options').hide();
}
}
`
Thoughts?
> Provide extensions a way to indicate that they can run only on primary node,
> if clustered
> -----------------------------------------------------------------------------------------
>
> Key: NIFI-543
> URL: https://issues.apache.org/jira/browse/NIFI-543
> Project: Apache NiFi
> Issue Type: Sub-task
> Components: Core Framework, Documentation & Website, Extensions
> Reporter: Mark Payne
> Assignee: Sivaprasanna Sethuraman
> Priority: Major
>
> There are Processors that are known to be problematic if run from multiple
> nodes simultaneously. These processors should be able to use a
> @PrimaryNodeOnly annotation (or something similar) to indicate that they can
> be scheduled to run only on primary node if run in a cluster.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
