[
https://issues.apache.org/jira/browse/NIFI-5121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452856#comment-16452856
]
ASF GitHub Bot commented on NIFI-5121:
--------------------------------------
GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/2658
NIFI-5121: Added DBCPService API method for passing in flow file attributes
when available
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mattyb149/nifi NIFI-5121
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2658.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2658
----
commit 17a1bbd781e93f718a50dbb0d462ac61a6170f0f
Author: Matthew Burgess <mattyb149@...>
Date: 2018-04-25T18:36:16Z
NIFI-5121: Added DBCPService API method for passing in flow file attributes
when available
----
> DBCPService should support passing in an attribute map when obtaining a
> connection
> ----------------------------------------------------------------------------------
>
> Key: NIFI-5121
> URL: https://issues.apache.org/jira/browse/NIFI-5121
> Project: Apache NiFi
> Issue Type: Improvement
> Reporter: Bryan Bende
> Assignee: Matt Burgess
> Priority: Minor
>
> Many users have asked for a way to obtain dynamic database connections.
> Essentially being able to use the existing SQL processors like PutSQL, etc,
> and be able to pass in flow file attributes to the DBCPService to obtain a
> connection based on the attributes.
> The current DBCPService interface has a single method:
> {code:java}
> Connection getConnection(){code}
> Since there is no way for a processor to pass in any information, we can add
> an additional method to this interface and make the interface like this:
> {code:java}
> Connection getConnection(Map<String,String> attributes)
> default Connection getConnection() {
> return getConnection(Collections.emptyMap());
> }{code}
> This would leave it up to the implementations of DBCPService interface to
> decide if they want to use the attributes map for anything.
> The DBCPConnectionPool would not use the attributes map and would continue to
> provide a fixed connection pool against a single data source.
> A new implementation can then be created that somehow maintains multiple
> connection pools, or creates connections on the fly.
> The PropertyDescriptors in each implementation should indicate how they use
> expression language.
> For example, since DBCPConnectionPool will not use the attribute map, it's
> property descriptors will indicate expression language scope as variable
> registry only:
> {code:java}
> .expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY){code}
> The dynamic implementations should indicate:
> {code:java}
> .expressionLanguageSupported(ExpressionLanguageScope.FLOWFILE_ATTRIBURES){code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
