[
https://issues.apache.org/jira/browse/NIFI-5123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16454285#comment-16454285
]
ASF GitHub Bot commented on NIFI-5123:
--------------------------------------
GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/2661
NIFI-5123: Move SchemaRegistryService to nifi-avro-record-utils
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mattyb149/nifi NIFI-5123
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2661.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2661
----
commit ee54d9156f23ec9738bf3f1724fbdabdaaa31540
Author: Matthew Burgess <mattyb149@...>
Date: 2018-04-26T14:19:41Z
NIFI-5123: Move SchemaRegistryService to nifi-avro-record-utils
----
> Enable extensions to use SchemaRegistryService
> ----------------------------------------------
>
> Key: NIFI-5123
> URL: https://issues.apache.org/jira/browse/NIFI-5123
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
> Reporter: Matt Burgess
> Assignee: Matt Burgess
> Priority: Major
>
> Currently SchemaRegistryService is in the nifi-record-serialization-services
> NAR, which means that other extensions (unless they had
> nifi-record-serialization-services-nar as a parent which is not recommended)
> cannot make use of this abstract class. The class uses utilities from
> nifi-avro-record-utils such as SchemaAccessUtils, and is a very helpful base
> class used to offer a consistent user experience for selecting schemas (by
> name, by test, from a schema registry, etc.). Other extensions wishing to
> provide access to a schema registry would duplicate much of the logic in
> SchemaRegistryService, which offers challenges for consistency and
> maintainability.
> This Jira proposes to move SchemaRegistryService into nifi-avro-record-utils,
> where it can be leveraged by any extension that depends on it, and thus we
> can strongly recommend that record-aware processors that will interact with a
> schema registry use SchemaRegistryService as a parent class.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
