Github user mattyb149 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2663#discussion_r184757401
  
    --- Diff: 
nifi-nar-bundles/nifi-site-to-site-reporting-bundle/nifi-site-to-site-reporting-task/src/main/java/org/apache/nifi/reporting/SiteToSiteBulletinReportingTask.java
 ---
    @@ -76,10 +81,16 @@
     
         private volatile long lastSentBulletinId = -1L;
     
    +    public SiteToSiteBulletinReportingTask() throws IOException {
    +        final InputStream schema = 
getClass().getClassLoader().getResourceAsStream("schema-bulletins.avsc");
    +        recordSchema = AvroTypeUtil.createSchema(new 
Schema.Parser().parse(schema));
    +    }
    +
         @Override
         protected List<PropertyDescriptor> getSupportedPropertyDescriptors() {
             final List<PropertyDescriptor> properties = new 
ArrayList<>(super.getSupportedPropertyDescriptors());
             properties.add(PLATFORM);
    +        properties.add(RECORD_WRITER);
    --- End diff --
    
    Is the intent here to allow all S2S Reporting Tasks to use the record 
writer if they want, or do we want to make it "mandatory" by including it in 
the properties from the abstract base class?


---

Reply via email to