[
https://issues.apache.org/jira/browse/NIFI-5122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16456959#comment-16456959
]
ASF GitHub Bot commented on NIFI-5122:
--------------------------------------
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2663#discussion_r184788317
--- Diff:
nifi-nar-bundles/nifi-site-to-site-reporting-bundle/nifi-site-to-site-reporting-task/src/main/java/org/apache/nifi/reporting/SiteToSiteBulletinReportingTask.java
---
@@ -76,10 +81,16 @@
private volatile long lastSentBulletinId = -1L;
+ public SiteToSiteBulletinReportingTask() throws IOException {
+ final InputStream schema =
getClass().getClassLoader().getResourceAsStream("schema-bulletins.avsc");
+ recordSchema = AvroTypeUtil.createSchema(new
Schema.Parser().parse(schema));
+ }
+
@Override
protected List<PropertyDescriptor> getSupportedPropertyDescriptors() {
final List<PropertyDescriptor> properties = new
ArrayList<>(super.getSupportedPropertyDescriptors());
properties.add(PLATFORM);
+ properties.add(RECORD_WRITER);
--- End diff --
Yeah I asked myself this question... I was not sure if it'd make sense to
move it to the abstract base class in case some users implemented custom
impl... but that wouldn't break anything (just the addition of an unused
property) so it's probably cleaner to have it in the abstract class. What's
your feeling?
> Add record writer to S2S Reporting Tasks
> ----------------------------------------
>
> Key: NIFI-5122
> URL: https://issues.apache.org/jira/browse/NIFI-5122
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
> Reporter: Pierre Villard
> Assignee: Pierre Villard
> Priority: Major
>
> Just like we have the option to specify a record writer for the new Site To
> Site Metrics Reporting Task, there should be the possibility to specify an
> optional record writer for the other S2S reporting tasks.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
