[
https://issues.apache.org/jira/browse/NIFI-5153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16464224#comment-16464224
]
ASF GitHub Bot commented on NIFI-5153:
--------------------------------------
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/2677
NIFI-5153: If a node is disconnected due to failure to complete mutab…
…le request, the node should be allowed to rejoin
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markap14/nifi NIFI-5153
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2677.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2677
----
commit ab7d56aaea7e313addd8578ab201d4935e93a617
Author: Mark Payne <markap14@...>
Date: 2018-05-04T13:31:51Z
NIFI-5153: If a node is disconnected due to failure to complete mutable
request, the node should be allowed to rejoin
----
> When a node fails to perform a mutable request, it should be asked to rejoin
> cluster instead of being disconnected
> ------------------------------------------------------------------------------------------------------------------
>
> Key: NIFI-5153
> URL: https://issues.apache.org/jira/browse/NIFI-5153
> Project: Apache NiFi
> Issue Type: Improvement
> Reporter: Mark Payne
> Assignee: Mark Payne
> Priority: Major
>
> Currently, if a mutable request (POST, PUT, DELETED) is issued to a cluster,
> the request is replicated and if any node fails to perform the request, it is
> disconnected (unless all nodes fail, in which case no node is disconnected).
> However, often times, the failure is due to some sort of socket timeout. As a
> result, we should request that the node re-join the cluster, as long as its
> flow matches the cluster's flow.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
