[
https://issues.apache.org/jira/browse/NIFI-5114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16464425#comment-16464425
]
ASF GitHub Bot commented on NIFI-5114:
--------------------------------------
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2652#discussion_r186227509
--- Diff:
nifi-nar-bundles/nifi-websocket-bundle/nifi-websocket-services-jetty/src/main/java/org/apache/nifi/websocket/jetty/JettyWebSocketClient.java
---
@@ -103,6 +107,35 @@
.defaultValue("10 sec")
.build();
+ public static final PropertyDescriptor USER_NAME = new
PropertyDescriptor.Builder()
+ .name("user-name")
+ .displayName("User Name")
+ .description("The user name for Basic Authentication.")
+ .required(false)
+
.expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY)
+ .addValidator(StandardValidators.NON_EMPTY_EL_VALIDATOR)
+ .build();
+
+ public static final PropertyDescriptor USER_PASSWORD = new
PropertyDescriptor.Builder()
+ .name("user-password")
+ .displayName("User Password")
+ .description("The user password for Basic Authentication.")
+ .required(false)
+
.expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY)
+ .addValidator(StandardValidators.NON_EMPTY_EL_VALIDATOR)
+ .sensitive(true)
+ .build();
+
+ public static final PropertyDescriptor AUTH_CHARSET = new
PropertyDescriptor.Builder()
+ .name("authentication-charset")
+ .displayName("Authentication Header Charset")
+ .description("The charset for Basic Authentication header
base64 string.")
+ .required(true)
+
.expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY)
+ .addValidator(StandardValidators.NON_EMPTY_EL_VALIDATOR)
+ .defaultValue("US-ASCII")
--- End diff --
Why not UTF-8?
> Support Basic Authentication at WebSocket components
> ----------------------------------------------------
>
> Key: NIFI-5114
> URL: https://issues.apache.org/jira/browse/NIFI-5114
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
> Reporter: Koji Kawamura
> Assignee: Koji Kawamura
> Priority: Major
>
> Some WebSocket server uses Basic Authentication for WebSocket upgrade
> requests. In order to connect such endpoints, NiFi should allow users to
> configure user name and password at WebSocket client component. Specifically
> JettyWebSocketClientService.
> In addition to that, if JettyWebSocketServerService can be configured to use
> Basic Authentication, it makes NiFi WebSocket server more secure and also
> useful to test Basic Auth between NiFi WebSocket client components.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
