Github user alopresto commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2684#discussion_r186502982
--- Diff:
nifi-toolkit/nifi-toolkit-tls/src/main/java/org/apache/nifi/toolkit/tls/manager/TlsClientManager.java
---
@@ -112,4 +112,9 @@ public void write(OutputStreamFactory
outputStreamFactory) throws IOException, G
public void
addClientConfigurationWriter(ConfigurationWriter<TlsClientConfig>
configurationWriter) {
configurationWriters.add(configurationWriter);
}
+
+
+ protected static String escapeAliasFilename(String alias) {
+ return alias.replaceAll("[^\\w&&[^\\.]]", "_");
--- End diff --
Recommend simplifying regular expression to `[^\\w\\.\\-\\n]+`.
Examples:
```
my/silly/filename my_silly_filename
my&silly&filename my_silly_filename
my silly alias my_silly_alias
my_silly_alias my_silly_alias
my.silly.alias my.silly.alias
my-silly-alias my-silly-alias
my silly alias my_silly_alias
my&/ silly*&$alias my_silly_alias
```
---
