[
https://issues.apache.org/jira/browse/NIFI-5161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16466286#comment-16466286
]
ASF GitHub Bot commented on NIFI-5161:
--------------------------------------
Github user alopresto commented on the issue:
https://github.com/apache/nifi/pull/2684
There are 8 checkstyle failures. You can identify these in IntelliJ using
the `nifi-checkstyle.xml` file available on the Apache NiFi Wiki in the
Contributor Guide, or on the command-line by running `mvn checkstyle:check`.
```
[INFO] --- maven-checkstyle-plugin:2.17:check (default-cli) @
nifi-toolkit-tls ---
[WARNING]
src/test/java/org/apache/nifi/toolkit/tls/manager/TlsClientManagerTest.java:[3,8]
(imports) UnusedImports: Unused import -
org.apache.nifi.toolkit.tls.configuration.TlsClientConfig.
[WARNING]
src/test/java/org/apache/nifi/toolkit/tls/manager/TlsClientManagerTest.java:[4,8]
(imports) UnusedImports: Unused import -
org.apache.nifi.toolkit.tls.configuration.TlsConfig.
[WARNING]
src/test/java/org/apache/nifi/toolkit/tls/manager/TlsClientManagerTest.java:[5,8]
(imports) UnusedImports: Unused import - org.junit.After.
[WARNING]
src/test/java/org/apache/nifi/toolkit/tls/manager/TlsClientManagerTest.java:[6,8]
(imports) UnusedImports: Unused import - org.junit.Before.
[WARNING]
src/test/java/org/apache/nifi/toolkit/tls/manager/TlsClientManagerTest.java:[9,8]
(imports) UnusedImports: Unused import - java.io.IOException.
[WARNING]
src/test/java/org/apache/nifi/toolkit/tls/manager/TlsClientManagerTest.java:[11,8]
(imports) UnusedImports: Unused import - java.lang.reflect.Method.
[WARNING]
src/test/java/org/apache/nifi/toolkit/tls/manager/TlsClientManagerTest.java:[12,8]
(imports) UnusedImports: Unused import -
java.security.GeneralSecurityException.
[WARNING]
src/test/java/org/apache/nifi/toolkit/tls/manager/TlsClientManagerTest.java:[14]
(imports) AvoidStarImport: Using the '.*' form of import should be avoided -
org.junit.Assert.*.
```
> Toolkit character escaping issue
> --------------------------------
>
> Key: NIFI-5161
> URL: https://issues.apache.org/jira/browse/NIFI-5161
> Project: Apache NiFi
> Issue Type: Bug
> Components: Tools and Build
> Reporter: Matt Gilman
> Assignee: Nathan Gough
> Priority: Minor
>
> The Java Keystore does not perform any character validation on the alias
> field, so theoretically a "/" character should be accepted. According to the
> Java documentation, the only instruction is "Whether aliases are case
> sensitive is implementation dependent. In order to avoid problems, it is
> recommended not to use aliases in a KeyStore that only differ in case."
> The toolkit will need to be updated to correctly escape special characters
> when passing them to the Java commands.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
