[
https://issues.apache.org/jira/browse/NIFI-5145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16470961#comment-16470961
]
ASF GitHub Bot commented on NIFI-5145:
--------------------------------------
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2672#discussion_r187427343
--- Diff:
nifi-mock/src/main/java/org/apache/nifi/util/MockPropertyValue.java ---
@@ -202,6 +203,9 @@ public PropertyValue evaluateAttributeExpressions(final
AttributeValueDecorator
@Override
public PropertyValue evaluateAttributeExpressions(final FlowFile
flowFile) throws ProcessException {
+ if (flowFile == null) {
--- End diff --
This feels a little bit odd to me, as it's very unclear just from looking
at this method what the intent is here - i think it would be cleaner to pass
down a boolean argument that indicates whether or not attributes are available.
It would be `true` in all cases except for `evaluateAttributeExpressions()`
with no arguments and `evaluateAttributeExpressions(AttributeValueDecorator
decorator)` - or otherwise to just have the no-arg version call the one that
takes only the decorator and implement that method there instead of calling
another override of the method. The actual implementation is only about 4-5
lines of code and quite trivial anyway.
> MockPropertyValue.evaluateExpressionLanguage(FlowFile) cannot handle null
> inputs
> --------------------------------------------------------------------------------
>
> Key: NIFI-5145
> URL: https://issues.apache.org/jira/browse/NIFI-5145
> Project: Apache NiFi
> Issue Type: Bug
> Reporter: Mike Thomsen
> Assignee: Mike Thomsen
> Priority: Major
>
> The method mentioned in the title line cannot handle null inputs, even though
> the main NiFi execution classes can handle that scenario. This forces hack to
> pass testing with nulls that looks like this:
> String val = flowFile != null ?
> context.getProperty(PROP).evaluateExpressionLanguage(flowfile).getValue() :
> context.getProperty(PROP).evaluateExpressionLanguage(new
> HashMap()).getValue();
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
