[ 
https://issues.apache.org/jira/browse/NIFI-5166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16472151#comment-16472151
 ] 

ASF GitHub Bot commented on NIFI-5166:
--------------------------------------

Github user mans2singh commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2686#discussion_r187655641
  
    --- Diff: 
nifi-nar-bundles/nifi-deeplearning4j-bundle/nifi-deeplearning4j-processors/src/main/java/org/apache/nifi/processors/deeplearning4j/AbstractDeepLearning4JProcessor.java
 ---
    @@ -0,0 +1,106 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.nifi.processors.deeplearning4j;
    +import java.io.IOException;
    +import org.apache.nifi.annotation.lifecycle.OnStopped;
    +import org.apache.nifi.components.PropertyDescriptor;
    +import org.apache.nifi.expression.ExpressionLanguageScope;
    +import org.apache.nifi.processor.AbstractProcessor;
    +import org.apache.nifi.processor.ProcessContext;
    +import org.apache.nifi.processor.util.StandardValidators;
    +import org.deeplearning4j.nn.multilayer.MultiLayerNetwork;
    +import org.deeplearning4j.util.ModelSerializer;
    +
    +/**
    + * Base class for deeplearning4j processors
    + */
    +public abstract class AbstractDeepLearning4JProcessor extends 
AbstractProcessor {
    --- End diff --
    
    @markap14  - This is to establish a foundation for future extensions which 
will be easier if some common base classes are present.   I found this pattern 
to be useful and hope it's not an overkill.


> Create deep learning classification and regression processor
> ------------------------------------------------------------
>
>                 Key: NIFI-5166
>                 URL: https://issues.apache.org/jira/browse/NIFI-5166
>             Project: Apache NiFi
>          Issue Type: New Feature
>          Components: Extensions
>    Affects Versions: 1.6.0
>            Reporter: Mans Singh
>            Assignee: Mans Singh
>            Priority: Minor
>              Labels: Learning, classification,, deep, regression,
>             Fix For: 1.7.0
>
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> We need a deep learning classification and regression processor.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to