[ https://issues.apache.org/jira/browse/NIFI-5170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16473030#comment-16473030 ]
ASF GitHub Bot commented on NIFI-5170: -------------------------------------- Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2691#discussion_r187720132 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExtractGrok.java --- @@ -80,18 +84,21 @@ public static final String FLOWFILE_ATTRIBUTE = "flowfile-attribute"; public static final String FLOWFILE_CONTENT = "flowfile-content"; private static final String APPLICATION_JSON = "application/json"; + private static final String DEFAULT_PATTERN_NAME = "/default-grok-patterns.txt"; public static final PropertyDescriptor GROK_EXPRESSION = new PropertyDescriptor.Builder() .name("Grok Expression") - .description("Grok expression") + .description("Grok expression. If other Grok expressions are referenced in this expression, they must be provided " + + "in the Grok Pattern File if set or exist in the default Grok patterns") .required(true) - .addValidator(validateGrokExpression()) + .addValidator(StandardValidators.NON_BLANK_VALIDATOR) --- End diff -- I think having a custom validator here was a better idea. Just checking that it's non-blank doesn't do much to help the user. > Update Grok to 0.1.9 > -------------------- > > Key: NIFI-5170 > URL: https://issues.apache.org/jira/browse/NIFI-5170 > Project: Apache NiFi > Issue Type: New Feature > Reporter: Otto Fowler > Assignee: Otto Fowler > Priority: Major > > Grok 0.1.9 has been released, including work for empty capture support. > > https://github.com/thekrakken/java-grok#maven-repository -- This message was sent by Atlassian JIRA (v7.6.3#76005)