[
https://issues.apache.org/jira/browse/NIFI-5077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16474232#comment-16474232
]
ASF GitHub Bot commented on NIFI-5077:
--------------------------------------
GitHub user ottobackwards opened a pull request:
https://github.com/apache/nifi/pull/2698
NIFI-5077 ExtractGrok support for `keep empty captures`
Support for the new option to keep empty captures. I did not add to the
GrokReader because I am not sure of the effect on
the schema extraction.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [-] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [-] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [-] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
I did not, in keeping with the current file
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ottobackwards/nifi grok-empty-captures
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2698.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2698
----
commit c5d44d56767effdbddeb66cc5c0ca89db670c6a1
Author: Otto Fowler <ottobackwards@...>
Date: 2018-05-14T13:35:23Z
NIFI-5077 ExtractGrok support for `keep empty captures`
Support for the new option to keep empty captures. I did not add to the
GrokReader because I am not sure of the effect on
the schema extraction.
----
> Grok support for Empty Captures
> -------------------------------
>
> Key: NIFI-5077
> URL: https://issues.apache.org/jira/browse/NIFI-5077
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
> Affects Versions: 1.6.0
> Environment: CentOS 7
> Reporter: Ramon de Graaff
> Assignee: Otto Fowler
> Priority: Major
> Attachments: grok.xml
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> Pattern matches but also attaches null values.
> grok-pattern:
> {{TEST %\{A}|%\{B}}}
> {{A %\{INT:test}}}
> {{B %\{INT:test}}}
> {{INT (?:[+-]?(?:[0-9]+))}}
> flowfile-content:
> {{1}}
> Flow file attributes after match:
> {{grok.A}}
> {{1}}
> {{grok.TEST}}
> {{1}}
> {{grok.test}}
> {{[1, null]}}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
