[ 
https://issues.apache.org/jira/browse/NIFI-4907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16475118#comment-16475118
 ] 

Mark Bean commented on NIFI-4907:
---------------------------------

In addition to basic unit testing, performed the following integration testing 
steps:

 

Remove ‘query provenance’ Global Policy; remove ‘view provenance’ Component 
Policy

Cannot query provenance; Global menu item grayed out; component menu item not 
displayed

Add ‘view provenance’ Component Policy at root Process Group. Still Global menu 
item grayed out; component menu item not displayed

Remove ‘view provenance’ Component Policy at root Process Group.

 

Create ‘query provenance’ Global Policy; add user

Global ‘Data Provenance’ runs query, but does not display any results

Component ‘View data provenance’ runs query, but does not display any results

 

Create ‘view provenance’ Component Policy at root Process Group; add user

Global ‘Data Provenance’ runs query, and displays all event results; Lineage 
graph displays all provenance events. Additional details are not available from 
the query results list nor lineage graph.

 

Create ‘view the data’ Component Policy at root Process Group; add user.

Global ‘Data Provenance’ runs query, and displays all event results; Lineage 
graph displays all provenance events. Additional details are available from the 
query results list and lineage graph.

 

Override ‘view provenance’ Component Policy for one component (e.g. 
GenerateFlowFile). 

Global ‘Data Provenance’ runs query, and displays all event results except 
CREATE event associated with Component whose policy was overridden. Lineage 
graph displays all provenance events with “CREATE” event being replaced by 
“UNKNOWN”. Attempting to double-click on the “UNKNOWN” event results in 
“Insufficient Permissions: Unable to view the provenance data for Processor 
with ID \{UUID}. Contact the system administrator.” Other lineage events allow 
access to additional details when double-clicked.

Component ‘View data provenance’ runs query, but does not display any results

 

Repeat with consistent results for Persistent, Volatile and Write-Ahead 
Provenance repository types

> Provenance authorization refactoring
> ------------------------------------
>
>                 Key: NIFI-4907
>                 URL: https://issues.apache.org/jira/browse/NIFI-4907
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Core Framework
>    Affects Versions: 1.5.0
>            Reporter: Mark Bean
>            Assignee: Mark Bean
>            Priority: Major
>
> Currently, the 'view the data' component policy is too tightly coupled with 
> Provenance queries. The 'query provenance' policy should be the only policy 
> required for viewing Provenance query results. Both 'view the component' and 
> 'view the data' policies should be used to refine the appropriate visibility 
> of event details - but not the event itself.
> 1) Component Visibility
> The authorization of Provenance events is inconsistent with the behavior of 
> the graph. For example, if a user does not have 'view the component' policy, 
> the graph shows this component as a "black box" (no details such as name, 
> UUID, etc.) However, when querying Provenance, this component will show up 
> including the Component Type and the Component Name. This is in effect a 
> violation of the policy. These component details should be obscured in the 
> Provenance event displayed if user does not have the appropriate 'view the 
> component' policy.
> 2) Data Visibility
> For a Provenance query, all events should be visible as long as the user 
> performing the query belongs to the 'query provenance' global policy. As 
> mentioned above, some information about the component may be obscured 
> depending on 'view the component' policy, but the event itself should be 
> visible. Additionally, details of the event (clicking the View Details "i" 
> icon) should only be accessible if the user belongs to the 'view the data' 
> policy for the affected component. If the user is not in the appropriate 
> 'view the data' policy, a popup warning should be displayed indicating the 
> reason details are not visible with more specific detail than the current 
> "Contact the system administrator".
> 3) Lineage Graphs
> As with the Provenance table view recommendation above, the lineage graph 
> should display all events. Currently, if the lineage graph includes an event 
> belonging to a component which the user does not have 'view the data', it is 
> shown on the graph as "UNKNOWN". As with Data Visibility mentioned above, the 
> graph should indicate the event type as long as the user is in the 'view the 
> component'. Subsequent "View Details" on the event should only be visible if 
> the user is in the 'view the data' policy.
> In summary, for Provenance query results and lineage graphs, all events 
> should be shown. Component Name and Component Type information should be 
> conditionally visible depending on the corresponding component policy 'view 
> the component' policy. Event details including Provenance event type and 
> FlowFile information should be conditionally available depending on the 
> corresponding component policy 'view the data'. Inability to display event 
> details should provide feedback to the user indicating the reason.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to