[
https://issues.apache.org/jira/browse/NIFI-5197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16477716#comment-16477716
]
ASF GitHub Bot commented on NIFI-5197:
--------------------------------------
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2706#discussion_r188696201
--- Diff:
nifi-nar-bundles/nifi-extension-utils/nifi-record-utils/nifi-avro-record-utils/src/main/java/org/apache/nifi/schema/access/SchemaAccessUtils.java
---
@@ -85,7 +85,7 @@
.description("Specifies the name of the branch to use when
looking up the schema in the Schema Registry property. " +
"If the chosen Schema Registry does not support
branching, this value will be ignored.")
.addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
- .expressionLanguageSupported(true)
+
.expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY)
--- End diff --
Can't SCHEMA_BRANCH_NAME and SCHEMA_VERSION possibly evaluate EL using
FlowFile attributes like SCHEMA_NAME (from
[SchemaNamePropertyStrategy](https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-extension-utils/nifi-record-utils/nifi-standard-record-utils/src/main/java/org/apache/nifi/schema/access/SchemaNamePropertyStrategy.java#L62))?
I traced the calls back to
[RecordReaderFactory](https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-service-api/src/main/java/org/apache/nifi/serialization/RecordReaderFactory.java#L46),
where you _might_ have FlowFile attributes available.
> Fix invalid expression language scope declarations
> --------------------------------------------------
>
> Key: NIFI-5197
> URL: https://issues.apache.org/jira/browse/NIFI-5197
> Project: Apache NiFi
> Issue Type: Bug
> Reporter: Mike Thomsen
> Assignee: Mike Thomsen
> Priority: Minor
>
> Some of the expression language scope declarations are wrong, such as
> declaring VARIABLE_REGISTRY and then passing in a flowfile as the argument in
> the processor. These need to be hunted down and cleaned up in one single
> commit. Each set of unit and integration tests should be run to verify where
> problems reside.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
