[ 
https://issues.apache.org/jira/browse/NIFI-5145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16477782#comment-16477782
 ] 

ASF GitHub Bot commented on NIFI-5145:
--------------------------------------

Github user mattyb149 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2672#discussion_r188710133
  
    --- Diff: 
nifi-mock/src/main/java/org/apache/nifi/util/MockPropertyValue.java ---
    @@ -202,6 +202,17 @@ public PropertyValue 
evaluateAttributeExpressions(final AttributeValueDecorator
     
         @Override
         public PropertyValue evaluateAttributeExpressions(final FlowFile 
flowFile) throws ProcessException {
    +        /*
    +         * TODO: Come up with a more elegation solution for this.
    --- End diff --
    
    I'll remove the TODO on merge


> MockPropertyValue.evaluateExpressionLanguage(FlowFile) cannot handle null 
> inputs
> --------------------------------------------------------------------------------
>
>                 Key: NIFI-5145
>                 URL: https://issues.apache.org/jira/browse/NIFI-5145
>             Project: Apache NiFi
>          Issue Type: Bug
>            Reporter: Mike Thomsen
>            Assignee: Mike Thomsen
>            Priority: Major
>
> The method mentioned in the title line cannot handle null inputs, even though 
> the main NiFi execution classes can handle that scenario. This forces hack to 
> pass testing with nulls that looks like this:
> String val = flowFile != null ? 
> context.getProperty(PROP).evaluateExpressionLanguage(flowfile).getValue() : 
> context.getProperty(PROP).evaluateExpressionLanguage(new 
> HashMap()).getValue();



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to