[
https://issues.apache.org/jira/browse/NIFI-5217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16481044#comment-16481044
]
ASF GitHub Bot commented on NIFI-5217:
--------------------------------------
GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/2720
NIFI-5217: Allow non-nullable fields to be added to MockRecordParser
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mattyb149/nifi NIFI-5217
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2720.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2720
----
commit d0ce41f202c63ff4f108abcd050506c525098568
Author: Matthew Burgess <mattyb149@...>
Date: 2018-05-18T18:47:57Z
NIFI-5217: Allow non-nullable fields to be added to MockRecordParser
----
> Allow MockRecordParser to add non-nullable fields
> -------------------------------------------------
>
> Key: NIFI-5217
> URL: https://issues.apache.org/jira/browse/NIFI-5217
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
> Reporter: Matt Burgess
> Assignee: Matt Burgess
> Priority: Major
>
> MockRecordParser (in nifi-mock-record-utils) has an addSchemaField() method,
> but it does not have a parameter to set whether the field is nullable or not.
> Thus it creates a new RecordField without the nullable parameter, in which
> case it defaults to "true". This prevents tests from adding a non-nullable
> field.
> This Jira proposes to overload addSchemaField() with a boolean "isNullable"
> parameter that will be passed along to the RecordField constructor.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
