Github user phrocker commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/333#discussion_r189747427
  
    --- Diff: libminifi/include/core/state/nodes/AgentInformation.h ---
    @@ -297,9 +297,20 @@ class ComponentManifest : public DeviceInformation {
                 descriptorRequired.name = "required";
                 descriptorRequired.value = prop.second.getRequired();
     
    +            SerializedResponseNode descriptorDependentProperties;
    +            descriptorDependentProperties.name = "dependentProperties";
    +
    +            for (const auto &propName : 
prop.second.getDependentProperties()) {
    +              SerializedResponseNode descriptorDependentProperty;
    +              descriptorDependentProperty.name = propName;
    +              descriptorDependentProperty.value = propName;
    --- End diff --
    
    why is the value the property name? You don't need a value if you just need 
a list. 


---

Reply via email to