[
https://issues.apache.org/jira/browse/NIFI-5229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16487605#comment-16487605
]
ASF GitHub Bot commented on NIFI-5229:
--------------------------------------
GitHub user bbende opened a pull request:
https://github.com/apache/nifi/pull/2735
NIFI-5229 Adding a DBCPService implementation that can lookup other D…
…BCPServices dynamically at runtime
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bbende/nifi NIFI-5229
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2735.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2735
----
commit 6bfb90019cb1404c63c4859e24586136e3c47534
Author: Bryan Bende <bbende@...>
Date: 2018-05-23T15:21:12Z
NIFI-5229 Adding a DBCPService implementation that can lookup other
DBCPServices dynamically at runtime
----
> Implement a DBCPConnectionPool that dynamically selects a connection pool
> -------------------------------------------------------------------------
>
> Key: NIFI-5229
> URL: https://issues.apache.org/jira/browse/NIFI-5229
> Project: Apache NiFi
> Issue Type: Improvement
> Reporter: Bryan Bende
> Priority: Major
>
> In NIFI-5121 we modified the DBCPConnectionPool interface to allow passing a
> map of attributes (https://issues.apache.org/jira/browse/NIFI-5121).
> We should implement a DBCPConnectionPool that lets you register multiple
> other connection pools via dynamic properties, and then selects one based on
> looking for an incoming attribute.
> For example, lets say you create two regular connection pools A and B, then
> in the new connection pool you would register:
> a = pool1
> b = pool2
> and then the new connection pool will look in the attribute map for an
> attribute like "database.id" and select the pool with the given id.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
