[
https://issues.apache.org/jira/browse/NIFI-5233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16489137#comment-16489137
]
ASF GitHub Bot commented on NIFI-5233:
--------------------------------------
Github user zenfenan commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2738#discussion_r190615976
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-hbase_1_1_2-client-service-bundle/nifi-hbase_1_1_2-client-service/src/test/java/org/apache/nifi/hbase/TestHBase_1_1_2_ClientService.java
---
@@ -119,9 +124,9 @@ public void testCustomValidate() throws
InitializationException, IOException {
// quorum, port, and znode, no conf file, should be valid
service = new MockHBaseClientService(table, COL_FAM,
kerberosPropsWithFile);
runner.addControllerService("hbaseClientService", service);
- runner.setProperty(service,
HBase_1_1_2_ClientService.ZOOKEEPER_QUORUM, "localhost");
- runner.setProperty(service,
HBase_1_1_2_ClientService.ZOOKEEPER_CLIENT_PORT, "2181");
- runner.setProperty(service,
HBase_1_1_2_ClientService.ZOOKEEPER_ZNODE_PARENT, "/hbase");
+ runner.setProperty(service,
HBase_1_1_2_ClientService.ZOOKEEPER_QUORUM, "${zk-quorum}");
+ runner.setProperty(service,
HBase_1_1_2_ClientService.ZOOKEEPER_CLIENT_PORT, "${zk-port}");
--- End diff --
Should be `zk-client-port`. Right?
> Enable expression language in Hadoop Configuration Files property of Hbase
> Client Service
> -----------------------------------------------------------------------------------------
>
> Key: NIFI-5233
> URL: https://issues.apache.org/jira/browse/NIFI-5233
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
> Affects Versions: 1.6.0
> Reporter: Gergely Devai
> Assignee: Pierre Villard
> Priority: Minor
> Labels: easyfix
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> In some Hadoop related processors (e.g. GetHDFS, DeleteHDFS) the "Hadoop
> Configuration Files" property supports expression language. This is
> convenient, as the lengthy paths to the config files can be stored in a
> property file loaded by Nifi at startup or in an environment variable, and
> the name of the property/environment variable can be referenced in the
> processors' configuration.
> The controller service HBase_1_1_2_ClientService also has the "Hadoop
> Configuration Files" property, but it does not support expression language.
> For the convenience reasons described above and for uniformity, it is
> desirable to allow expression language in that property as well.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
