[ 
https://issues.apache.org/jira/browse/NIFI-4838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16489210#comment-16489210
 ] 

ASF GitHub Bot commented on NIFI-4838:
--------------------------------------

Github user pvillard31 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2448#discussion_r190629391
  
    --- Diff: 
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/test/java/org/apache/nifi/processors/mongodb/GetMongoIT.java
 ---
    @@ -67,20 +69,23 @@
     
         @Before
         public void setup() {
    -        runner = TestRunners.newTestRunner(GetMongo.class);
    +        runner = TestRunners.newTestRunner(TestGetMongo.class);
             runner.setVariable("uri", MONGO_URI);
             runner.setVariable("db", DB_NAME);
             runner.setVariable("collection", COLLECTION_NAME);
             runner.setProperty(AbstractMongoProcessor.URI, "${uri}");
             runner.setProperty(AbstractMongoProcessor.DATABASE_NAME, "${db}");
             runner.setProperty(AbstractMongoProcessor.COLLECTION_NAME, 
"${collection}");
    -        runner.setProperty(GetMongo.USE_PRETTY_PRINTING, GetMongo.YES_PP);
    +        runner.setProperty(GetMongo.USE_PRETTY_PRINTING, GetMongo.GM_TRUE);
             runner.setIncomingConnection(false);
    +        runner.setValidateExpressionUsage(true);
    --- End diff --
    
    I believe that's the default here, probably best to not have this line


> Make GetMongo support multiple commits and give some progress indication
> ------------------------------------------------------------------------
>
>                 Key: NIFI-4838
>                 URL: https://issues.apache.org/jira/browse/NIFI-4838
>             Project: Apache NiFi
>          Issue Type: Improvement
>            Reporter: Mike Thomsen
>            Assignee: Mike Thomsen
>            Priority: Major
>
> It shouldn't wait until the end to do a commit() call because the effect is 
> that GetMongo looks like it has hung to a user who is pulling a very large 
> data set.
> It should also have an option for running a count query to get the current 
> approximate count of documents that would match the query and append an 
> attribute that indicates where a flowfile stands in the total result count. 
> Ex:
> query.progress.point.start = 2500
> query.progress.point.end = 5000
> query.count.estimate = 17,568,231



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to