Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2703#discussion_r190921900
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/FlowController.java
---
@@ -3669,12 +3664,10 @@ public FlowRegistryClient getFlowRegistryClient() {
@Override
public ControllerServiceNode createControllerService(final String
type, final String id, final BundleCoordinate bundleCoordinate, final Set<URL>
additionalUrls, final boolean firstTimeAdded) {
- // make sure the first reference to LogRepository happens outside
of a NarCloseable so that we use the framework's ClassLoader
- final LogRepository logRepository =
LogRepositoryFactory.getRepository(id);
--- End diff --
I don't think we can move this line. This needs to happen outside of the
NarCloseable. Please refer to JIRA it was added for additional information.
https://issues.apache.org/jira/browse/NIFI-5136
---
