[
https://issues.apache.org/jira/browse/NIFI-5247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16493191#comment-16493191
]
ASF GitHub Bot commented on NIFI-5247:
--------------------------------------
GitHub user pepov opened a pull request:
https://github.com/apache/nifi/pull/2746
NIFI-5247 NiFi toolkit signal handling changes, Dockerfile enhancements
nifi-toolkit bash entry points should leverage exec to replace bash with
the current java process in order to handle signals properly in docker. Also
add bash, openssl, jq to make certificate request operations easier
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pepov/nifi NIFI-5247
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2746.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2746
----
commit f20b05b8560426ee3c195d2480379771cee066f3
Author: pepov <peterwilcsinszky@...>
Date: 2018-05-24T14:15:55Z
NIFI-5247 nifi-toolkit bash entry points should leverage exec to replace
bash with the current java process in order to handle signals properly in
docker. Also add bash, openssl, jq to make certificate request operations easier
----
> NiFi toolkit signal handling changes, Dockerfile enhancements
> -------------------------------------------------------------
>
> Key: NIFI-5247
> URL: https://issues.apache.org/jira/browse/NIFI-5247
> Project: Apache NiFi
> Issue Type: Bug
> Components: Tools and Build
> Affects Versions: 1.6.0, 1.7.0
> Reporter: Peter Wilcsinszky
> Priority: Minor
>
> 1. Signal handling issues
> In order for processes to handle signals properly in Docker we have to
> implement explicit signal handling for the first process in the container. In
> the case of the NiFi toolkit the easiest solution is to replace the bash
> shell with the Java process and let it handle the signal using the exec
> system call. More detailed explanation of the issue:
> [http://veithen.github.io/2014/11/16/sigterm-propagation.html]
> Relevant issues: NIFI-3505 and NIFI-2689 that already added exec to the run
> invocation of the nifi.sh start script.
> This changes makes stopping containers fast and graceful.
> 2. TLS toolkit commands and basic tooling in the container
> In order to be able to request certificates from a running CA server instance
> some tooling is needed inside the container. These tools are openssl for
> checking ssl certificates and endpoints, and jq for config.json processing. A
> complete use case is available in the following NiFi helm chart:
> [https://github.com/pepov/apache-nifi-helm/blob/master/templates/statefulset.yaml#L75]
>
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
