[
https://issues.apache.org/jira/browse/MINIFICPP-513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16493789#comment-16493789
]
ASF GitHub Bot commented on MINIFICPP-513:
------------------------------------------
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/346#discussion_r191486678
--- Diff: libminifi/include/io/NetworkPrioritizer.h ---
@@ -86,10 +92,15 @@ class NetworkInterface {
friend class NetworkPrioritizer;
std::string ifc_;
std::shared_ptr<NetworkPrioritizer> prioritizer_;
-};
+}
+;
--- End diff --
We can't really do that since we have a custom google style format, but
thanks for pointing that out.
> RVO causing seg fault due to taking reference to transient
> -----------------------------------------------------------
>
> Key: MINIFICPP-513
> URL: https://issues.apache.org/jira/browse/MINIFICPP-513
> Project: NiFi MiNiFi C++
> Issue Type: Bug
> Reporter: marco polo
> Assignee: marco polo
> Priority: Major
>
> RVO causing seg fault due to taking reference to transient on certain
> compilers. Additionally, during profiling found that elision was prevented,
> so we should avoid using the rvalue reference for the return and move
> semantics and let the compiler take care of the optimization.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
