Github user mattyb149 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2663#discussion_r191634954
  
    --- Diff: 
nifi-nar-bundles/nifi-site-to-site-reporting-bundle/nifi-site-to-site-reporting-task/src/main/resources/docs/org.apache.nifi.reporting.SiteToSiteStatusReportingTask/additionalDetails.html
 ---
    @@ -50,7 +50,7 @@ <h2>Record writer</h2>
        { "name" : "actorHostname", "type" : "string"},
        { "name" : "componentType", "type" : "string"},
        { "name" : "componentName", "type" : "string"},
    -   { "name" : "parentId", "type" : "string"},
    +   { "name" : "parentId", "type" : ["string", "null"]},
    --- End diff --
    
    That looks VERY familiar but I think even the first time we dealt with Avro 
it might have been 1.7.x after it had been fixed (plus that had to do with 
default values being supported with unions). Maybe I'm thinking of a NiFi 
Record API bug with unions and defaults. But either way, if this LGTY it LGTM :)


---

Reply via email to